Remove vendor folder from harbor code base #19508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #19508 +/- ##
===========================================
- Coverage 67.50% 45.01% -22.50%
===========================================
Files 988 243 -745
Lines 108777 13354 -95423
Branches 2737 2737
===========================================
- Hits 73432 6011 -67421
+ Misses 31384 7039 -24345
+ Partials 3961 304 -3657
Flags with carried forward coverage won't be shown. Click here to find out more. |
reasonerjt
force-pushed
the
rm-vendor
branch
3 times, most recently
from
14bc356 to
8a37a8f
Compare
Signed-off-by: Daniel Jiang <[email protected]>
reasonerjt
changed the title
reasonerjt
assigned wy65701436, stonezdj and chlins and unassigned OrlinVasilev and AllForNothing
reasonerjt
added a commit
to reasonerjt/harbor
that referenced
this pull request
Nov 6, 2023
There's a path change introduced by goharbor#19508 which may impact showing the coverage on codecov. This commit makes sure the profile.cov is referenced as absolute path in `coverage4gotest.sh` Signed-off-by: Daniel Jiang <[email protected]>
5 tasks
reasonerjt
added a commit
to reasonerjt/harbor
that referenced
this pull request
Nov 6, 2023
There's a path change introduced by goharbor#19508 which may impact showing the coverage on codecov. This commit makes sure the profile.cov is referenced as absolute path in `coverage4gotest.sh` Signed-off-by: Daniel Jiang <[email protected]>
chlins
pushed a commit
that referenced
this pull request
Nov 6, 2023
There's a path change introduced by #19508 which may impact showing the coverage on codecov. This commit makes sure the profile.cov is referenced as absolute path in `coverage4gotest.sh` Signed-off-by: Daniel Jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the vendor folder, also update the Makefile to remove the dependency of the vendor folder
Fixes #18346
Please indicate you've done the following: