Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full permissions for the robot account #19507

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Oct 31, 2023

  1. Fixes Implement the UI for robot accounts full permissions #19353
  2. Expose full permissions for the robot account
  3. Refactor the UI with the Clarity Wizard component
  4. Screenshots:
image image image image image image

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner October 31, 2023 02:29
@AllForNothing AllForNothing assigned AllForNothing and unassigned Vad1mo, zyyw and chlins Oct 31, 2023
@AllForNothing AllForNothing added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #19507 (1daaff2) into main (5c02fd8) will increase coverage by 0.04%.
The diff coverage is 40.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19507      +/-   ##
==========================================
+ Coverage   67.51%   67.55%   +0.04%     
==========================================
  Files         989      990       +1     
  Lines      109034   108998      -36     
  Branches     2737     2719      -18     
==========================================
+ Hits        73615    73635      +20     
+ Misses      31453    31396      -57     
- Partials     3966     3967       +1     
Flag Coverage Δ
unittests 67.55% <40.89%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/portal/src/app/shared/shared.module.ts 100.00% <ø> (ø)
...e/project/robot-account/robot-account.component.ts 36.53% <80.00%> (+2.07%) ⬆️
...-robot-accounts/system-robot-accounts.component.ts 36.25% <75.00%> (+2.73%) ⬆️
...ide-nav/system-robot-accounts/system-robot-util.ts 64.06% <62.96%> (-1.73%) ⬇️
...ccounts/projects-modal/projects-modal.component.ts 31.03% <26.31%> (-18.97%) ⬇️
...issions-panel/robot-permissions-panel.component.ts 62.50% <62.50%> (ø)
...ect/robot-account/add-robot/add-robot.component.ts 22.22% <14.81%> (+1.49%) ⬆️
...s/list-all-projects/list-all-projects.component.ts 29.41% <31.25%> (-18.05%) ⬇️
...em-robot-accounts/new-robot/new-robot.component.ts 21.62% <16.66%> (+2.37%) ⬆️

... and 4 files with indirect coverage changes

@OrlinVasilev
Copy link
Member

@AllForNothing the CI has failed can you check please, great job though :)

@AllForNothing
Copy link
Contributor Author

@OrlinVasilev The related back-end code is still under development, this PR should be merged after that. So we need to wait for the back-end PR to be merged first.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the UI for robot accounts full permissions
6 participants