-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full permissions for the robot account #19507
Conversation
Codecov Report
@@ Coverage Diff @@
## main #19507 +/- ##
==========================================
+ Coverage 67.51% 67.55% +0.04%
==========================================
Files 989 990 +1
Lines 109034 108998 -36
Branches 2737 2719 -18
==========================================
+ Hits 73615 73635 +20
+ Misses 31453 31396 -57
- Partials 3966 3967 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@AllForNothing the CI has failed can you check please, great job though :) |
@OrlinVasilev The related back-end code is still under development, this PR should be merged after that. So we need to wait for the back-end PR to be merged first. |
1.Fixes goharbor#19353 Signed-off-by: AllForNothing <[email protected]>
7eaadc6
to
1daaff2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: