Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security hub UI test case #19448

Merged

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Oct 16, 2023

Fix #19270

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@YangJiao0817 YangJiao0817 force-pushed the add-security-hub-ui-testcase branch from 2d017d1 to ef497d7 Compare October 16, 2023 08:06
@YangJiao0817 YangJiao0817 enabled auto-merge (squash) October 16, 2023 08:10
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #19448 (ef497d7) into main (2c36770) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19448      +/-   ##
==========================================
+ Coverage   67.44%   67.45%   +0.01%     
==========================================
  Files         988      988              
  Lines      108732   108732              
  Branches     2752     2752              
==========================================
+ Hits        73329    73341      +12     
+ Misses      31458    31449       -9     
+ Partials     3945     3942       -3     
Flag Coverage Δ
unittests 67.45% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@YangJiao0817 YangJiao0817 merged commit ec0ef17 into goharbor:main Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add security hub UI test case
5 participants