Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong artifact scanned count #19198

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Aug 16, 2023

fixes #19197

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner August 16, 2023 12:27
@stonezdj stonezdj added the release-note/update Update or Fix label Aug 16, 2023
@stonezdj stonezdj force-pushed the 23aug16_wrong_scanned branch from 31d0309 to 103b52b Compare August 16, 2023 12:30
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #19198 (15ff76e) into main (52e6615) will increase coverage by 22.51%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19198       +/-   ##
===========================================
+ Coverage   44.89%   67.41%   +22.51%     
===========================================
  Files         244      993      +749     
  Lines       13412   108866    +95454     
  Branches     2751     2751               
===========================================
+ Hits         6021    73389    +67368     
- Misses       7086    31532    +24446     
- Partials      305     3945     +3640     
Flag Coverage Δ
unittests 67.41% <ø> (+22.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/pkg/securityhub/dao/security.go 59.60% <ø> (ø)

... and 749 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 23aug16_wrong_scanned branch from 103b52b to 139c3cc Compare August 16, 2023 13:59
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 23aug16_wrong_scanned branch from 139c3cc to 3aceb34 Compare August 17, 2023 02:52
@stonezdj stonezdj force-pushed the 23aug16_wrong_scanned branch from 3aceb34 to 15ff76e Compare August 17, 2023 03:15
@stonezdj stonezdj merged commit 83ff2b2 into goharbor:main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Hub not scanned field is incorrect
5 participants