-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update zh-tw (Traditional Chinese) locale #19161
Conversation
Codecov Report
@@ Coverage Diff @@
## main #19161 +/- ##
==========================================
+ Coverage 67.40% 67.42% +0.01%
==========================================
Files 993 993
Lines 108864 108864
Branches 2751 2751
==========================================
+ Hits 73382 73402 +20
+ Misses 31535 31516 -19
+ Partials 3947 3946 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
de7fda9
to
5ccb49b
Compare
@PeterDaveHello Very lovely to see a follow-up PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Share my POV
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve all the comments
5ccb49b
to
023ffeb
Compare
Signed-off-by: Peter Dave Hello <[email protected]>
023ffeb
to
4dbb9ab
Compare
@AllForNothing looks like we are good to go! |
Improve zh-tw (Traditional Chinese) locale again. This is a follow up of #18608, and this time I try to refer to the en-us locale, also compare more references for the terms, although there are still some terms or strings not very perfect yet(I mean it's hard to be translated), hopefully the zh-tw language is at least more consistent and localized here now.
Please indicate you've done the following: