Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove chartmuseum backend #18191

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Feb 8, 2023

Harbor deprecates chartmuseum as of v2.8.0

Epic: #17958
Discussion: #15057

Signed-off-by: Wang Yan [email protected]

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #18191 (2f44303) into main (ec5afc3) will increase coverage by 0.52%.
The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18191      +/-   ##
==========================================
+ Coverage   66.60%   67.13%   +0.52%     
==========================================
  Files         999      971      -28     
  Lines      108145   105162    -2983     
  Branches     2579     2579              
==========================================
- Hits        72035    70601    -1434     
+ Misses      32148    30814    -1334     
+ Partials     3962     3747     -215     
Flag Coverage Δ
unittests 67.13% <41.66%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/rbac/project/rbac_role.go 70.00% <ø> (ø)
src/common/rbac/project/rbac_util.go 65.71% <ø> (ø)
src/controller/artifact/processor/processor.go 100.00% <ø> (ø)
src/controller/event/topic.go 6.47% <ø> (-1.98%) ⬇️
src/controller/health/checker.go 34.35% <ø> (+3.10%) ⬆️
src/controller/systeminfo/controller.go 62.90% <ø> (-0.59%) ⬇️
src/core/api/base.go 4.21% <ø> (-23.07%) ⬇️
src/jobservice/job/impl/replication/replication.go 49.36% <ø> (-8.87%) ⬇️
src/lib/config/systemconfig.go 50.76% <ø> (+1.49%) ⬆️
src/lib/selector/candidate.go 50.00% <ø> (ø)
... and 45 more

@wy65701436 wy65701436 added the release-note/deprecation Harbor Deprecation MUST need to be in release notes label Feb 8, 2023
@wy65701436 wy65701436 force-pushed the rm-build-chart branch 9 times, most recently from ee734d1 to 3a2772c Compare February 9, 2023 17:02
@wy65701436 wy65701436 closed this Feb 9, 2023
@wy65701436 wy65701436 reopened this Feb 9, 2023
@wy65701436 wy65701436 closed this Feb 11, 2023
@wy65701436 wy65701436 reopened this Feb 11, 2023
@wy65701436 wy65701436 force-pushed the rm-build-chart branch 6 times, most recently from dc74ee0 to 72bab97 Compare February 11, 2023 12:35
@wy65701436 wy65701436 force-pushed the rm-build-chart branch 6 times, most recently from 8547929 to 857a8bb Compare February 14, 2023 06:39
@chlins
Copy link
Member

chlins commented Feb 15, 2023

@chlins
Copy link
Member

chlins commented Feb 15, 2023

Source code structure mentioned chartserver in the https://github.com/goharbor/harbor/blob/main/CONTRIBUTING.md.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj
Copy link
Contributor

Harbor deprecates chartmuseum as of v2.8.0

Epic: goharbor#17958

Discussion: goharbor#15057

Signed-off-by: Wang Yan <[email protected]>
Copy link
Contributor

@stonezdj stonezdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wy65701436 wy65701436 merged commit 738fde7 into goharbor:main Feb 16, 2023
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
Harbor deprecates chartmuseum as of v2.8.0

Epic: goharbor#17958

Discussion: goharbor#15057

Signed-off-by: Wang Yan <[email protected]>
Signed-off-by: Stephan Hohn <[email protected]>
sebglon pushed a commit to sebglon/harbor that referenced this pull request Mar 6, 2023
Harbor deprecates chartmuseum as of v2.8.0

Epic: goharbor#17958

Discussion: goharbor#15057

Signed-off-by: Wang Yan <[email protected]>
mathieulaude added a commit to cloud-pi-native/console that referenced this pull request Apr 11, 2024
mathieulaude added a commit to cloud-pi-native/console that referenced this pull request Apr 11, 2024
mathieulaude added a commit to cloud-pi-native/console that referenced this pull request Apr 11, 2024
this-is-tobi pushed a commit to cloud-pi-native/console that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/deprecation Harbor Deprecation MUST need to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants