-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove chartmuseum backend #18191
remove chartmuseum backend #18191
Conversation
47a556d
to
6cec9f9
Compare
Codecov Report
@@ Coverage Diff @@
## main #18191 +/- ##
==========================================
+ Coverage 66.60% 67.13% +0.52%
==========================================
Files 999 971 -28
Lines 108145 105162 -2983
Branches 2579 2579
==========================================
- Hits 72035 70601 -1434
+ Misses 32148 30814 -1334
+ Partials 3962 3747 -215
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6cec9f9
to
18334ee
Compare
ee734d1
to
3a2772c
Compare
dc74ee0
to
72bab97
Compare
8547929
to
857a8bb
Compare
The chart legacy APIs should also be cleaned from swagger. |
Source code structure mentioned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
+1 |
Harbor deprecates chartmuseum as of v2.8.0 Epic: goharbor#17958 Discussion: goharbor#15057 Signed-off-by: Wang Yan <[email protected]>
31c7149
to
fe46e6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Harbor deprecates chartmuseum as of v2.8.0 Epic: goharbor#17958 Discussion: goharbor#15057 Signed-off-by: Wang Yan <[email protected]> Signed-off-by: Stephan Hohn <[email protected]>
Harbor deprecates chartmuseum as of v2.8.0 Epic: goharbor#17958 Discussion: goharbor#15057 Signed-off-by: Wang Yan <[email protected]>
Harbor deprecates chartmuseum as of v2.8.0
Epic: #17958
Discussion: #15057
Signed-off-by: Wang Yan [email protected]
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: