Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick]Improve double star validator on UI #14357

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

AllForNothing
Copy link
Contributor

Cherry-pick #14345
Signed-off-by: AllForNothing [email protected]

@AllForNothing AllForNothing self-assigned this Mar 4, 2021
Copy link
Contributor

@xuelichao xuelichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #14357 (7740987) into release-2.2.0 (21dc98a) will decrease coverage by 0.02%.
The diff coverage is 38.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.2.0   #14357      +/-   ##
=================================================
- Coverage          63.93%   63.91%   -0.03%     
=================================================
  Files                954      954              
  Lines              63746    63779      +33     
  Branches            2171     2181      +10     
=================================================
+ Hits               40758    40762       +4     
- Misses             19008    19032      +24     
- Partials            3980     3985       +5     
Flag Coverage Δ
unittests 63.91% <38.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rovider/add-p2p-policy/add-p2p-policy.component.ts 45.85% <0.00%> (ø)
...tegration/tag-retention/tag-retention.component.ts 34.06% <0.00%> (-0.38%) ⬇️
...ation/immutable-tag/add-rule/add-rule.component.ts 52.68% <40.00%> (-1.34%) ⬇️
...ation/tag-retention/add-rule/add-rule.component.ts 35.11% <40.00%> (-0.09%) ⬇️
...pp/project/p2p-provider/policy/policy.component.ts 54.01% <47.36%> (-0.82%) ⬇️
...tegration/immutable-tag/immutable-tag.component.ts 71.87% <50.00%> (-1.25%) ⬇️
src/controller/event/handler/auditlog/auditlog.go 57.89% <0.00%> (-5.27%) ⬇️
src/common/utils/passports.go 84.61% <0.00%> (-5.13%) ⬇️
src/controller/event/topic.go 9.00% <0.00%> (-1.81%) ⬇️
...ig/vulnerability/vulnerability-config.component.ts 56.94% <0.00%> (-1.39%) ⬇️

@AllForNothing AllForNothing merged commit 340921d into goharbor:release-2.2.0 Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants