Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contrib/registry/zookeeper): zookeeper_discovery.go 和regitster不一致,缺失name节点 #4147

Closed
wants to merge 2 commits into from

Conversation

fengpengyun
Copy link

bug: zk register中的节点层级和discovery的不一致

bug: zk register中的节点层级和discovery的不一致
@fengpengyun fengpengyun changed the title fix: zookeeper_discovery.go 和regitster不一致,确实name节点 fix: zookeeper_discovery.go 和regitster不一致,缺失name节点 Feb 10, 2025
@fengpengyun fengpengyun changed the title fix: zookeeper_discovery.go 和regitster不一致,缺失name节点 fix(contrib/registry/zookeeper): zookeeper_discovery.go 和regitster不一致,缺失name节点 Feb 10, 2025
@fengpengyun fengpengyun changed the title fix(contrib/registry/zookeeper): zookeeper_discovery.go 和regitster不一致,缺失name节点 feat(contrib/registry/zookeeper): zookeeper_discovery.go 和regitster不一致,缺失name节点 Feb 11, 2025
@gqcn
Copy link
Member

gqcn commented Feb 14, 2025

@fengpengyun 你好,感谢参与开源贡献!目前CI运行失败了,请解决一下。另外,麻烦一并增加对应修改的单测哈,辛苦了。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@fengpengyun Hello, thanks for participating in the open source contribution! Currently, CI is running failed, please resolve it. In addition, please add the corresponding modifications to the single test, thank you for your hard work.

@fengpengyun
Copy link
Author

这个问题正确的处理方式应该是我提的issue,所以这个pr我就关闭了。
@gqcn

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


The correct way to deal with this problem should be the issue I mentioned, so I closed this pr.
@gqcn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants