Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cmd/gen): improve comments for command gen dao #4007

Merged
merged 7 commits into from
Dec 7, 2024
Merged

Conversation

houseme
Copy link
Member

@houseme houseme commented Dec 5, 2024

improve comment

@houseme houseme changed the title docs(cmd/gen): improve dao group comment docs(cmd/gen): improve gen dao comment Dec 5, 2024
@houseme houseme requested review from gqcn and hailaz December 5, 2024 04:17
@gqcn
Copy link
Member

gqcn commented Dec 5, 2024

@houseme Comment变化了,对应的单测都会失败。。。需要都改了😅

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@houseme If Comment changes, the corresponding single test will fail. . . All needs have been changed.

@houseme
Copy link
Member Author

houseme commented Dec 5, 2024

@houseme Comment变化了,对应的单测都会失败。。。需要都改了😅

再改,太多了,哈哈

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@houseme If Comment changes, the corresponding single test will fail. . . Everything needs to be changed😅

If you change it again, it will be too much, haha

@gqcn
Copy link
Member

gqcn commented Dec 5, 2024

@houseme Comment变化了,对应的单测都会失败。。。需要都改了😅

再改,太多了,哈哈

总感觉咱们这种单测不是很优雅,一点有点风吹草动改动有点大,但是我一时半会也没想到更好的改进方案。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@houseme If Comment changes, the corresponding single test will fail. . . Everything needs to be changed😅

Change again, too many, haha

I always feel that our single test is not very elegant, and the changes are a bit rough, but I haven't thought of a better improvement plan for a while.

@houseme
Copy link
Member Author

houseme commented Dec 5, 2024

@houseme Comment变化了,对应的单测都会失败。。。需要都改了😅

再改,太多了,哈哈

总感觉咱们这种单测不是很优雅,一点有点风吹草动改动有点大,但是我一时半会也没想到更好的改进方案。

慢慢来,积累中成长

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@houseme If Comment changes, the corresponding single test will fail. . . Everything needs to be changed😅

Change again, too many, haha

I always feel that our single test is not very elegant, and the changes are a bit rough, but I haven't thought of a better improvement plan for a while.

Take your time and grow through accumulation

@gqcn gqcn changed the title docs(cmd/gen): improve gen dao comment docs(cmd/gen): improve comments for command gen dao Dec 7, 2024
@gqcn gqcn changed the title docs(cmd/gen): improve comments for command gen dao docs(cmd/gen): improve comments for command gen dao Dec 7, 2024
@gqcn gqcn merged commit e18331a into master Dec 7, 2024
40 checks passed
@gqcn gqcn deleted the fix/dao-comment branch December 7, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants