Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix bug preventing non-utf8 characters being saved in some databases #87

Merged
merged 8 commits into from
May 6, 2021

Conversation

hi019
Copy link
Contributor

@hi019 hi019 commented Apr 11, 2021

Fixes gofiber/fiber#1258

TODO:

  • Write migration instructions
  • Create schema check function for Postgres
  • Create schema check function for MySQL
  • Create schema check function for SQLITE
  • Move migration instructions to MIGRATION.md

Postgres:

ALTER TABLE fiber_storage 
ALTER COLUMN v TYPE BYTEA USING v::bytea;

MYSQL:

ALTER TABLE fiber_storage MODIFY COLUMN v BLOB;

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Apr 11, 2021
@hi019 hi019 force-pushed the fix-postgres-save branch from 48a49b7 to 5d232d2 Compare April 11, 2021 19:01
@hi019 hi019 requested review from Fenny and ReneWerner87 April 25, 2021 04:49
mysql/mysql.go Outdated Show resolved Hide resolved
mysql/mysql.go Outdated Show resolved Hide resolved
sqlite3/sqlite3.go Outdated Show resolved Hide resolved
sqlite3/sqlite3.go Outdated Show resolved Hide resolved
mysql/config.go Outdated Show resolved Hide resolved
@hi019 hi019 marked this pull request as ready for review May 3, 2021 16:27
@hi019 hi019 requested a review from ReneWerner87 May 3, 2021 16:27
@hi019
Copy link
Contributor Author

hi019 commented May 4, 2021

LGTM

@hi019 hi019 merged commit 6a0f72c into main May 6, 2021
@hi019 hi019 deleted the fix-postgres-save branch May 6, 2021 01:17
@ReneWerner87
Copy link
Member

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☢️ Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Sessions] pq: invalid byte sequence for encoding "UTF8": 0xff
2 participants