✨ feature: integrate SSL mode for PG connections #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thx can you deposit some test for it, which will test the effect of the code change |
r-52
force-pushed
the
r-postgres-ssl-mode-option
branch
from
2b82292 to
75c3314
Compare
I've integrate a test for this change that checks the behavior. What do you think? |
|
looks okay |
ReneWerner87
approved these changes
Apr 14, 2021
|
@r-52 could you add the new configuration possibility in the readme after that i will merge everything |
|
@r-52 could you do this? |
|
@ReneWerner87 sorry, I missed the ping :/ I'll take a look at it and ping you when it's done |
|
ok :D |
|
@r-52 and don´t forget to resolve the merge conflicts by updating your branch |
Right now, the default connection for postgres is `disable`. Some databases require `verify` or even `required`. This PR introduces a new implementation that allows the user to override the `disable` mode. The PR keeps a backwards compatible config entry, that sets the default behavior to `disable` if it's missing.
r-52
force-pushed
the
r-postgres-ssl-mode-option
branch
from
75c3314 to
4ea7d71
Compare
|
@ReneWerner87 Sorry for the delay. The conflict is resolved and I've added a new README entry for the new configuration option 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the default connection for postgres is
disable. Some databases requireverifyor evenrequired. This PR introduces a new implementation that allows the user to override thedisablemode. The PR keeps a backwards compatible config entry, that sets the default behavior todisableif it's missing.