Drop go 1.16 support & add go 1.20

[gaby]

• Remove support for go 1.16 from all storage drivers
• Add go 1.20 to test matrix of each storage driver
• Add macos-latest to test matrix of each storage driver
• Run go mod tidy on each driver
• Added matrix test to vulnerability and security workflows
• Fixed the platform field for each workflow (was hardcoded to ubuntu-latest)

[sixcolors]

@gaby looks good to me so far. But, I’m getting blurry eyed. I’ll run tests locally tomorrow just to see if anything odd comes up on actual macOS vs macOS-latest in the ci.

Thanks for the PR!

[gaby]

I just realized... These test are not actually running on each OS. They all have the same "runs-on" hardcoded to ubuntu-latest

[sixcolors]

I just realized... These test are not actually running on each OS. They all have the same "runs-on" hardcoded to ubuntu-latest

told you I’m getting blurry eyed. 🥱🛌

runs-on: ${{ matrix.platform }}

[gaby]

gosec requires go 1.19 to run, not sure how it was even working before?

[gaby]

I just realized... These test are not actually running on each OS. They all have the same "runs-on" hardcoded to ubuntu-latest

told you I’m getting blurry eyed. 🥱🛌

runs-on: ${{ matrix.platform }}

We are running Docker containers for several test, and these are only support on Linux

[gaby]

Don't merge yet, I forgot to remove the platforms from each test. Most of the tests can only run in "ubuntu-latest".

This will reduce the number of jobs created by the CI

[sixcolors]

Don't merge yet, I forgot to remove the platforms from each test. Most of the tests can only run in "ubuntu-latest".

This will reduce the number of jobs created by the CI

True and probably not worth the effort to install on the host, although many of them run multi-platform (Postgres, MySQL, redis etc). It’s probably safe to assume deployments are overwhelmingly using Linux based containers.

examples of some actions that could allow us to use matrix runs-on in CI:

https://github.com/marketplace/actions/setup-postgresql-for-linux-macos-windows
https://github.com/marketplace/actions/actions-setup-redis
https://github.com/ankane/setup-mysql

[gaby]

Don't merge yet, I forgot to remove the platforms from each test. Most of the tests can only run in "ubuntu-latest".
This will reduce the number of jobs created by the CI

True and probably not worth the effort to install on the host, although many of them run multi-platform (Postgres, MySQL, redis etc). It’s probably safe to assume deployments are overwhelmingly using Linux based containers.

examples of some actions that could allow us to use matrix runs-on in CI:

github.com/marketplace/actions/setup-postgresql-for-linux-macos-windows github.com/marketplace/actions/actions-setup-redis ankane/setup-mysql

Awesome, I will add those then. Removing the platforms reduce the number of tests down to less than 40

[sixcolors]

Awesome, I will add those then. Removing the platforms reduce the number of tests down to less than 40

The same guy did a bunch, I guess he needed them for the same reason:

https://github.com/ankane/setup-mysql#related-actions

Anyway, I'm happy with the PR. Did you have more commits?

[sixcolors]

LGTM

[gaby]

@sixcolors Discussing on discord what to do about the missing platforms.