Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

badger: update storage to use badgerV3 #68

Merged
merged 6 commits into from
Mar 31, 2021
Merged

badger: update storage to use badgerV3 #68

merged 6 commits into from
Mar 31, 2021

Conversation

Jictyvoo
Copy link
Contributor

@Jictyvoo Jictyvoo commented Mar 28, 2021

Implementing a new version of badger to fix problems with WSL, as discussed in #67

  • Add compatibility with Badger-V3
  • Add badger config to storage config options
  • Check the corresponding of WithTruncate function

TODO:
- Add badger config to storage config options
- Check the corresponding of WithTruncate function
Updated README as well with new configs
@ReneWerner87
Copy link
Member

first of all thanks for the contribution

instead of making a new version in the extra folder, what do you think about replacing the old version ?

@Jictyvoo
Copy link
Contributor Author

first of all thanks for the contribution

instead of making a new version in the extra folder, what do you think about replacing the old version ?

The problem with replacing the old version is data in v1 being incompatible with v2, which is also incompatible with v3 But if you see no problem, I can replace instead of creating a new folder

@ReneWerner87
Copy link
Member

yes no problem, we will mention this in the new release, people should update

@Jictyvoo
Copy link
Contributor Author

Done

badger/badger.go Outdated Show resolved Hide resolved
@Jictyvoo Jictyvoo changed the title Create badger v3 storage badger: update storage to use badgerV3 Mar 29, 2021
@Jictyvoo
Copy link
Contributor Author

Jictyvoo commented Mar 31, 2021

I'm think it's finished

@ReneWerner87 ReneWerner87 merged commit f69705a into gofiber:main Mar 31, 2021
@ReneWerner87 ReneWerner87 linked an issue Mar 31, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[badger] - Add support to newer badger versions (2.0 or above)
2 participants