Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github/workflows/security): install gosec fails with package embed is not in GOROOT #272

Merged
merged 11 commits into from
Jan 10, 2022

Conversation

sixcolors
Copy link
Member

@sixcolors sixcolors commented Nov 20, 2021

security workflow runs gosec which needs go version > 1.16 but install v1.15.15; package embed is not in GOROOT

bumps deps

closes #271

@sixcolors sixcolors marked this pull request as draft November 20, 2021 15:47
@sixcolors sixcolors marked this pull request as ready for review November 20, 2021 15:51
@sixcolors
Copy link
Member Author

Not sure what snyk is complaining about, don't have access. Otherwise I'm pretty sure this PR is good.

@sixcolors sixcolors changed the title fix: security workflow gosec package embed is not in GOROOT fix(github/workflows/security): install gosec fails with package embed is not in GOROOT Nov 20, 2021
@sixcolors
Copy link
Member Author

Hey @ReneWerner87 there was also a missing exclude on the root gosec run; fixed with 660a7fs

@ReneWerner87 ReneWerner87 added the ☢️ Bug Something isn't working label Jan 10, 2022
@ReneWerner87 ReneWerner87 merged commit 864b9a0 into gofiber:main Jan 10, 2022
@ReneWerner87 ReneWerner87 added the 🤖 Dependencies Pull requests that update a dependency file label Jan 10, 2022
@sixcolors sixcolors deleted the 271-workflow-security-go-version branch January 10, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☢️ Bug Something isn't working 🤖 Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 bug(github/workflows/security): installing go version < 1.16 with pkg embeds
2 participants