Skip to content

Commit

Permalink
Do not run timing sensitive tests in parallel
Browse files Browse the repository at this point in the history
  • Loading branch information
gaby committed Mar 4, 2024
1 parent b337ee1 commit 53b0530
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 19 deletions.
31 changes: 16 additions & 15 deletions internal/memory/memory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,48 +9,49 @@ import (
)

// go test -run Test_Memory -v -race

func Test_Memory(t *testing.T) {
t.Parallel()
store := New()
var (
key = "john"
val any = []byte("doe")
exp = 1 * time.Second
)

// Set key with value
store.Set(key, val, 0)
store.Set(key, val, 0)

result := store.Get(key)
require.Equal(t, val, result)

// Get non-existing key
result = store.Get("empty")
require.Equal(t, nil, result)
require.Nil(t, result)

// Set key with value and ttl
store.Set(key, val, exp)
time.Sleep(1100 * time.Millisecond)

result = store.Get(key)
require.Equal(t, nil, result)
require.Nil(t, result) // TODO: This is failing

// Set key with value and no expiration
store.Set(key, val, 0)
result = store.Get(key)
require.Equal(t, val, result)

// Delete key
store.Delete(key)
result = store.Get(key)
require.Equal(t, nil, result)
require.Nil(t, result)

store.Set("john", val, 0)
store.Set("doe", val, 0)
// Reset all keys
store.Set("john-reset", val, 0)
store.Set("doe-reset", val, 0)
store.Reset()

result = store.Get("john")
require.Equal(t, nil, result)

result = store.Get("doe")
require.Equal(t, nil, result)
// Check if all keys are deleted
result = store.Get("john-reset")
require.Nil(t, result)
result = store.Get("doe-reset")
require.Nil(t, result)
}

// go test -v -run=^$ -bench=Benchmark_Memory -benchmem -count=4
Expand Down
1 change: 0 additions & 1 deletion middleware/logger/logger_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,6 @@ func getLatencyTimeUnits() []struct {

// go test -run Test_Logger_WithLatency
func Test_Logger_WithLatency(t *testing.T) {
t.Parallel()
buff := bytebufferpool.Get()
defer bytebufferpool.Put(buff)
app := fiber.New()
Expand Down
6 changes: 3 additions & 3 deletions middleware/proxy/proxy_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -487,11 +487,11 @@ func Test_Proxy_DoTimeout_Timeout(t *testing.T) {

app := fiber.New()
app.Get("/test", func(c fiber.Ctx) error {
return DoTimeout(c, "http://"+addr, time.Second)
return DoTimeout(c, "http://"+addr, 1*time.Second)
})

_, err1 := app.Test(httptest.NewRequest(fiber.MethodGet, "/test", nil), int((1*time.Second)/time.Millisecond))
require.Equal(t, errors.New("test: timeout error 1000ms"), err1)
_, err1 := app.Test(httptest.NewRequest(fiber.MethodGet, "/test", nil), int((1*time.Second)/(10*time.Millisecond)))
require.Equal(t, errors.New("test: timeout error 100ms"), err1)
}

// go test -race -run Test_Proxy_DoDeadline_RestoreOriginalURL
Expand Down

0 comments on commit 53b0530

Please sign in to comment.