Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix closing dropdown on EditorResourcePicker in Single Window Mode #99653

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix closing dropdown on EditorResourcePicker in Single Window Mode #99653

merged 1 commit into from
Dec 20, 2024

Conversation

Giganzo
Copy link
Contributor

@Giganzo Giganzo commented Nov 24, 2024

Fixes: #96191

@Giganzo Giganzo requested a review from a team as a code owner November 24, 2024 22:53
@Chaosus Chaosus added this to the 4.4 milestone Nov 25, 2024
KoBeWi
KoBeWi approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OptionButton uses PRESS mode by default, so this makes sense.

@Repiteo Repiteo merged commit 34797fa into godotengine:master Dec 20, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 20, 2024

Thanks!

@Giganzo Giganzo mentioned this pull request Jan 19, 2025
Merged
@Giganzo Giganzo deleted the deselect-dropdown-in-single-window-mode branch January 19, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Not possible to deselect Dropdown list with activated Single Window Mode
4 participants
@Giganzo @Repiteo @KoBeWi @Chaosus