Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inability to set TextureLayeredRD as TEXTURE_TYPE_CUBE or TEXTURE_TYPE_CUBE_ARRAY #98767

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

jadeharley2
Copy link
Contributor

…_TYPE_CUBE_ARRAY

Should resolve #93915

@jadeharley2 jadeharley2 requested review from a team as code owners November 2, 2024 18:30
@AThousandShips AThousandShips added bug topic:rendering cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Nov 3, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Nov 3, 2024
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for turning this into a PR

@Repiteo
Copy link
Contributor

Repiteo commented Nov 10, 2024

Please squash your commits into one, see the interactive rebase for details

@jadeharley2 jadeharley2 reopened this Nov 11, 2024
@jadeharley2
Copy link
Contributor Author

Redone changes (with pre-commit checks) on updated repository. (github was stuck on processing updates after rebase)

@akien-mga akien-mga changed the title Fix inability to set TextureLayeredRD as TEXTURE_TYPE_CUBE or TEXTURE… Fix inability to set TextureLayeredRD as TEXTURE_TYPE_CUBE or TEXTURE_TYPE_CUBE_ARRAY Nov 11, 2024
@akien-mga akien-mga changed the title Fix inability to set TextureLayeredRD as TEXTURE_TYPE_CUBE or TEXTURE_TYPE_CUBE_ARRAY Fix inability to set TextureLayeredRD as TEXTURE_TYPE_CUBE or TEXTURE_TYPE_CUBE_ARRAY Nov 11, 2024
@Repiteo Repiteo merged commit 7464510 into godotengine:master Nov 11, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 11, 2024

Thanks! Congratulations on your first contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextureCubemapRD can't be sampled as a cubemap
4 participants