Fix run instances dialog scaling bug #98568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:editor
cherrypick:4.3
AThousandShips
approved these changes
Oct 27, 2024
KoBeWi
reviewed
Nov 25, 2024
|
Rebased and amended with KoBeWi's suggestion. |
akien-mga
approved these changes
Dec 2, 2024
|
Thanks! Congratulations on your first merged contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98537
The EDSCALE variable (a float) was being multiplied to the Vector2i, and since Vector2i only has a * operator for int, EDSCALE would get rounded down. This meant that if the display scale was 0.75, it would get rounded to 0 and the dialog would open up with it's minimum size. With this change, the round happens after the multiplication.