Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ColorPicker's remote synchronization when typing values #98567

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

ydeltastar
Copy link
Contributor

When typing + enter in a ColorPicker, the color didn't synch in the running project.

@ydeltastar ydeltastar requested a review from a team as a code owner October 26, 2024 22:04
@Calinou Calinou added bug topic:editor cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 26, 2024
@Calinou Calinou added this to the 4.4 milestone Oct 26, 2024
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

Note that this does not fix the situation where you change the color by holding Ctrl while pressing Enter in any of the fields - or when you drag sliders without closing the dialog. This keeps the dialog open after confirming the color selection, so it will show up in the editor (and affect what you see in the editor viewport), but not in the running project. The color will only apply to the running project once you close the ColorPicker.

That said, this is already an improvement over the existing situation, so I think this can be merged now. It could also be argued that this behavior can be beneficial in some cases, e.g. to compare "before" and "after" situations in a single view with two windows side-by-side.

@ydeltastar
Copy link
Contributor Author

ydeltastar commented Oct 27, 2024

so it will show up in the editor (and affect what you see in the editor viewport), but not in the running project. The color will only apply to the running project once you close the ColorPicker.

I wanted to make it update with any changes like in the editor. The lack of realtime changes defeats the purpose of live synchronization. But the picker and others like the transform gizmos only update once, so I thought the synchronization was supposed to work in "undo-redo commit style" by design.

Now that I think about it, only the transform gizmos and the color picker work like this... Most property inspectors update in realtime.

@Repiteo Repiteo merged commit 185a86a into godotengine:master Nov 26, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 26, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:editor usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency when editing color pickers in debug mode
4 participants