Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make possible to scale multiple nodes at once in the canvas editor #98534

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

YeldhamDev
Copy link
Member

This PR makes possible to change the scale of multiple selected canvas items at once:

Screencast_20241025_163951.webm

And adds some smaller improvements:

  • Make the "scale" gizmo be positioned at the temporary pivot when used.
  • Show the "move" gizmo when multiple items are selected (no idea why this wasn't done sooner).

Sponsored By: 🐺 Lone Wolf Technology / 🍀 W4 Games.

@KoBeWi
Copy link
Member

KoBeWi commented Oct 25, 2024

When in Select mode, pressing Ctrl+Alt will show scale gizmo, but pressing Alt does not show move gizmo.

godot.windows.editor.dev.x86_64_bgD7PZffpG.mp4

@fire
Copy link
Member

fire commented Oct 25, 2024

In 3D mode, the local mode and non local mode affects scaling of multiple objects in standard but weird ways.

Reference note for if someone was trying to match behaviour.

#68804

@YeldhamDev
Copy link
Member Author

@KoBeWi

When in Select mode, pressing Ctrl+Alt will show scale gizmo, but pressing Alt does not show move gizmo.

This seems to be unrelated to my PR, as pressing Alt on stable/master doesn't show it either. I can try to fix this too if that's what you meant with your message.

@KoBeWi
Copy link
Member

KoBeWi commented Oct 25, 2024

I mean, you added move gizmo when move tool is active. Also the scale gizmo showing is also coming from this PR. So it's related.

EDIT:
Ok I checked again and the scale showing was already there, just for one node. So the move improvement can be done later.

@KoBeWi
Copy link
Member

KoBeWi commented Oct 25, 2024

Another thing, which is partially pre-existing bug, is that pressing Ctrl+Alt in move mode will display scale gizmo and with temp pivot you can see 2 gizmos at once.
image

Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from that little double gizmo bug, looks good.

@YeldhamDev
Copy link
Member Author

@KoBeWi Only the "Scale" shortcut actually works outside of the "Selection" mode. I wonder if this was an oversight and the behavior should be removed.

@KoBeWi
Copy link
Member

KoBeWi commented Oct 30, 2024

Yep, I'd remove it.

@YeldhamDev
Copy link
Member Author

@KoBeWi @AThousandShips Changes made.

@Repiteo Repiteo merged commit 9513d18 into godotengine:master Nov 14, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 14, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants