Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selecting root node before button released #98232

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Fix selecting root node before button released #98232

merged 1 commit into from
Nov 10, 2024

Conversation

dbnicholson
Copy link
Contributor

In order to test if the button press is within the scene tree, the Tree's coordinates should be used, not the SceneTreeEditor's.

Fixes #78001

@dbnicholson
Fix selecting root node before button released
b05aab4 
In order to test if the button press is within the scene tree, the
Tree's coordinates should be used, not the SceneTreeEditor's.
@dbnicholson dbnicholson requested a review from a team as a code owner October 16, 2024 11:51
@AThousandShips AThousandShips added bug topic:editor usability cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 16, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Oct 16, 2024
Sauermann
Sauermann approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@Sauermann Sauermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR rebased on 58a7f9b and it seems to fix the bug.
Can't say anything about the implementation.

akien-mga
akien-mga approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Repiteo Repiteo merged commit 68c35f4 into godotengine:master Nov 10, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 10, 2024

Thanks! Congratulations on your first contribution! 🎉

@dbnicholson dbnicholson deleted the editor-dock-select-root branch November 10, 2024 20:56
@dbnicholson dbnicholson mentioned this pull request Nov 21, 2024
Closed
@Spartan322 Spartan322 mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@Sauermann Sauermann Sauermann approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:editor usability
Projects
None yet
Milestone
4.4
5 participants
@dbnicholson @Repiteo @akien-mga @Sauermann @AThousandShips