Fixed setting our system_fbo framebuffer #9823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
system_fbo was being assigned before visual_server->init() was called, the result was that it got cleared.
Also set_base_framebuffer copied the global gl_view_base_fb which hasn't been set yet when it gets called. I think its obsolete anyway because the iOS framebuffer gets created before init() is called on visual server.
Note that this whole thing should be re-examined. It creates and destroys the iOS framebuffer 3 times. I haven't had time to look into that further. It may be smart to investigate using NSOpenGLView so we piggy back on all the latest changes Apple has added into this especially since al the rendering happens in framebuffers in the render engine itself.