Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide white circle outline during instant transformations #96766

Merged

Conversation

ryevdokimov
Copy link
Contributor

This is described in a comment just above relevant code as "rotation white outline", which implies to me it was meant just to visually unify the rotation gizmo. This PR makes it hidden during instant transformations.

Before:

2024-09-09.11-43-43.mp4

After:

2024-09-09.12-03-21.mp4

@ryevdokimov ryevdokimov requested a review from a team as a code owner September 9, 2024 19:05
@AThousandShips AThousandShips added this to the 4.x milestone Sep 10, 2024
@ryevdokimov
Copy link
Contributor Author

This is technically a bug I believe, should have probably put "fix" in the title.

@Calinou Calinou added bug topic:3d cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release and removed enhancement labels Sep 19, 2024
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This circle is indeed meant to be drawn only when the rotato gizmo is visible, so it should be hidden during instant transform operations.

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Sep 19, 2024
@akien-mga akien-mga merged commit 71a7e37 into godotengine:master Sep 19, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:editor topic:3d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants