Fix jumping to editor help does not scroll correctly sometimes #96449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:editor
cherrypick:4.3
Maran23
force-pushed
the
editor-help-scroll-fix
branch
from
10a0930 to
af92685
Compare
KoBeWi
approved these changes
Nov 24, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #96448
Fixes: #96515
The whole
go to helpcode was executed twice for no reason, which led to the broken scrolling sometimes and to the somewhat hacky fix done in #90035 to fix that most of the time.Turns out that the original PR, that fixed something else but led to the scrolling regression, done in #82498 was actually close to being correct. It removed the duplicate tab change, but actually the 'wrong' one.
In this PR, we remove the other duplicate that does excactly the same code again which was previously already done. This fixes the scrolling and allows us to revert the
draw connectcode to how it was done previously. Also made the sure that the issue #82292 which was fixed in #82498 still does not happen.