-
-
Notifications
You must be signed in to change notification settings - Fork 21.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash when division by zero/modulo by zero happen on vectors #95172
Fix crash when division by zero/modulo by zero happen on vectors #95172
Conversation
ca43819
to
22694e1
Compare
9d26276
to
ce265d9
Compare
ce265d9
to
dfff6d3
Compare
dfff6d3
to
63dbf59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic behind this makes sense to me, but I'm not well-versed in the GDScript codegen implementation.
63dbf59
to
a0799ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long delay! Added some comments, mostly about tests.
modules/gdscript/tests/scripts/runtime/errors/op_by_zero/division_by_zero_int.gd
Outdated
Show resolved
Hide resolved
modules/gdscript/tests/scripts/runtime/errors/op_by_zero/division_by_zero_int.gd
Outdated
Show resolved
Hide resolved
a0799ed
to
ff49ab7
Compare
ff49ab7
to
0524e29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks! |
Vector*i
divide by zero crash #95168Will now correctly finish with error, instead of silent crash.