Fix goto line issues in code editor #94002
Merged
+38
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paulb23
reviewed
Jul 30, 2024
| state["column"] = 0; | ||
| state["scroll_position"] = members_overview->get_item_metadata(p_idx); | ||
| se->set_edit_state(state); | ||
| CodeTextEditor *cte = se->get_code_editor(); |
There was a problem hiding this comment.
Can't say I like the idea of the ScriptEditorPlugin interacting with the code editor directly, would prefer changing the API (combine them with a new arg?) or as above cast to the specific type.
|
Updated to use a cast, as elsewhere in |
Paulb23
approved these changes
Aug 3, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goto_line_selection)goto_line).I did not change the goto line popup since I have another PR about that #91388.
Removed the
p_with_errorargument since it isn't used. There are some other uses ofgoto_linethat could use the new column argument, but I'll leave that for another PR.