-
-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix property type of Sprite3D frame_coords
to Vector2i from Vector2
#93982
Conversation
The class reference file needs to also be changed (concerningly, none of the tests picked up on this) |
@Mickeon Presumably, the class reference is generated by reference to the getter type and does not need to be fixed. Both getters and setters had their type as Vector2i, but only PropertyInfo was incorrectly registered as Vector2, this PR fixes it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this personally. It breaks compatibility, sure, but it does as much as a bugfix would. Unsure it should be in 4.3, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't break compat in C# because the generated bindings use the type of the getter/setter as the property type. So the C# property was already using the Vector2i type.
So regarding C# compat this change is fine 👍
That is actually shockingly fantastic, I think this is fine for 4.3 then |
Thanks! |
The setter and getter types are correct, and there is probably no problem with compatibility since the only change is the type hint when binding.