Check device texture size limits in RenderingDevice::texture_create
#93819
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carbonyte
force-pushed
the
check-device-limits
branch
2 times, most recently
from
4a13d49 to
809b94b
Compare
Mickeon
reviewed
Jul 1, 2024
clayjohn
added
the
cherrypick:4.3
akien-mga
force-pushed
the
check-device-limits
branch
from
809b94b to
16ee2f2
Compare
|
Rebased and amended with suggested style improvements. |
AThousandShips
approved these changes
Dec 2, 2024
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93798.
The actual limit may be higher on a per-format basis, but as this information isn't exposed to GDScript I opted to use the global limits.