Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fix exporting as ZIP when console wrapper and/or embedded PCK is enabled. #89511

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Mar 15, 2024

Fixes #89501

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bruvzg bruvzg marked this pull request as ready for review March 15, 2024 10:07
@bruvzg bruvzg requested a review from a team as a code owner March 15, 2024 10:07
@akien-mga akien-mga merged commit c9c17d6 into godotengine:master Mar 15, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 15, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporting Windows build as zip with 'Embed PCK' on, causes the exe to be missing from the zip
2 participants