-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Try to use "borderless fullscreen" is "borderless" flag is set. #88735
base: master
Are you sure you want to change the base?
Conversation
If needed, I can test this on my AMD GPU. :)
|
Tested on AMD APU as well (as expected there's no difference, but unlike NVidia multiwindow support is not completely broken even in exclusive fs, it's just switched to non-exclusive mode when another window is open). |
Yes, but set the borderless flag first. For the reference behavior on NVidia is:
|
It's not a perfect solution, but I did not find any issues, and should not be compatibility breaking. |
Shouldn't it be the other way around? I thought In other words, I'd expect this instead:
|
It is the other way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally (rebased on top of master
23191b8), I can't see any difference on Windows 11 22H2 with a GeForce RTX 4090 (NVIDIA 551.61). Alt-tabbing doesn't cause flickering when in exclusive fullscreen mode, but that's also the case on master
without this PR.
I'd typically use Special K to diagnose the actual window mode seen by the OS but I can't get it to work with Godot (pressing Ctrl + Shift + Backspace to show its overlay does nothing).
I tested this locally on Windows 10, Intel + NVIDIA (Optimus, Intel as primary GPU), no noticeable differences between both modes on either GPU with OpenGL, Vulkan or D3D12. |
Oh no, you probably should only swap |
Partially addresses #63500, by allowing to set both
WINDOW_FLAG_BORDERLESS
andWINDOW_MODE_EXCLUSIVE_FULLSCREEN
.WINDOW_FLAG_BORDERLESS
will have no effect and still enter exclusive mode).