Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Switch to 0x0A00 (Windows 10) as a primary version and fix build with new target. #88486

Closed
wants to merge 1 commit into from

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Feb 18, 2024

  • Fixes build with target version set to 0x0A00 (Windows 10).
  • Adds version check depending on "d3d12" flag.
  • Sets default target to 0x0A00 (Windows 10).

See #88466

@bruvzg bruvzg marked this pull request as ready for review February 18, 2024 12:17
@bruvzg bruvzg requested a review from a team as a code owner February 18, 2024 12:17
@bruvzg
Copy link
Member Author

bruvzg commented Feb 18, 2024

Actually, I have looked at DX loading, and doing it dynamically might be much easier than I was thinking, probably less than 10 functions, so this might be unnecessary.

@bruvzg
Copy link
Member Author

bruvzg commented Feb 18, 2024

Superseded by #88496, we can keep Windows 7/8.1 support for now.

@bruvzg bruvzg closed this Feb 18, 2024
@bruvzg bruvzg removed this from the 4.3 milestone Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants