[3.x] SCons: Fix Web build when compiler version isn't properly detected #87739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick fix for godotengine#82585. A better fix requires refactoring the way we detect the compiler version to make it more reliable, and get a consistent output. But I prefer to keep changes minimal for 3.x branches at this point. Also set CI version to 3.1.39, which is what we use for official 3.6 builds since 3.6-beta4.
akien-mga
added
bug
platform:web
topic:buildsystem
cherrypick:3.5
akien-mga
deleted the
3.x-scons-web-workaround-emscripten-version-check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for #82585.
A better fix requires refactoring the way we detect the compiler version to make it more reliable, and get a consistent output. But I prefer to keep changes minimal for 3.x branches at this point.
Also set CI version to 3.1.39, which is what we use for official 3.6 builds since 3.6-beta4.
Note to self: That part shouldn't be cherry-picked to
3.5, and the hardcoded version should be(3, 1, 14).