Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix touch events in WebXR with an "immersive-ar" session #85521

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Nov 29, 2023

Fixes #85482

This was a problem with calculating the position of touch events. It looks like the bug was introduced in PR #56819, and was fixed for Godot 4 as part of PR #68870, but the fix never got backported to Godot 3.

This PR is backporting the fix!

@dsnopek dsnopek added this to the 3.6 milestone Nov 29, 2023
@dsnopek dsnopek requested a review from a team as a code owner November 29, 2023 20:59
@dsnopek dsnopek added the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Nov 29, 2023
@dsnopek dsnopek changed the title Fix touch events in WebXR with an "immersive-ar" session [3.x] Fix touch events in WebXR with an "immersive-ar" session Nov 29, 2023
@jeisoncp
Copy link

jeisoncp commented Dec 5, 2023

I have built the fixed template and test with my project. It's works! Touch inputs now are working properly.

@dsnopek
Copy link
Contributor Author

dsnopek commented Dec 5, 2023

Great! Thanks for testing :-)

@akien-mga akien-mga merged commit ee883ce into godotengine:3.x Dec 8, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.4.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Jan 30, 2024
@dsnopek dsnopek deleted the webxr-fix-ar-position-godot3 branch July 22, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants