Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Add project settings for AVAudioSessionCategory on iOS #83409

Merged
merged 1 commit into from
Jan 10, 2024
Merged

[3.x] Add project settings for AVAudioSessionCategory on iOS #83409

merged 1 commit into from
Jan 10, 2024

Conversation

jfriv
Copy link

@jfriv jfriv commented Oct 15, 2023

Adds project settings for AVAudioSessionCategory on iOS, duplicate of #81196 for 3.x

@jfriv jfriv changed the base branch from 3.x to 3.5 October 15, 2023 18:10
@Calinou Calinou added bug platform:ios topic:porting topic:audio cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Oct 15, 2023
@Calinou Calinou added this to the 3.6 milestone Oct 15, 2023
@AThousandShips
Copy link
Member

You need to target 3.x and then can be cherry picked for 3.5

@jfriv jfriv force-pushed the add-audiosession-options branch from 712f54d to 278ee36 Compare October 15, 2023 20:36
@jfriv jfriv changed the base branch from 3.5 to 3.x November 4, 2023 21:52
@jfriv jfriv force-pushed the add-audiosession-options branch from 278ee36 to f55d151 Compare November 4, 2023 22:00
@jfriv jfriv marked this pull request as ready for review November 15, 2023 15:17
@jfriv jfriv requested review from a team as code owners November 15, 2023 15:17
@AThousandShips AThousandShips changed the title Add audiosession options [3.x] Add audiosession options Nov 15, 2023
@akien-mga akien-mga changed the title [3.x] Add audiosession options [3.x] Add project settings for AVAudioSessionCategory on iOS Jan 5, 2024
@akien-mga
Copy link
Member

This looks good, but the project setting names should likely be changed to match the ones merged in #81196. Could you do those changes?

Note: Please make modifications by amending the commit, and force pushing the changes, so that it stays as a single commit (see PR workflow).

@bruvzg bruvzg mentioned this pull request Jan 8, 2024
Closed
@akien-mga akien-mga force-pushed the add-audiosession-options branch from f55d151 to 739d27a Compare January 10, 2024 12:34
@akien-mga
Copy link
Member

This looks good, but the project setting names should likely be changed to match the ones merged in #81196. Could you do those changes?

I did that, and added @georgwacker as co-author since this was ported from their code.

@akien-mga akien-mga merged commit 4126326 into godotengine:3.x Jan 10, 2024
13 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@jfriv
Copy link
Author

jfriv commented Jan 29, 2024

Thank you for making these additional changes for me! Also thank you to @georgwacker for adding AVAudioSessionCategory options for iOS in 4.x, he deserves all the credit 😄

@jfriv jfriv deleted the add-audiosession-options branch January 29, 2024 01:19
@akien-mga
Copy link
Member

Cherry-picked for 3.5.4.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Jan 30, 2024
@akien-mga akien-mga changed the title [3.x] Add project settings for AVAudioSessionCategory on iOS [3.x] Add project settings for AVAudioSessionCategory on iOS Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
bug platform:ios topic:audio topic:porting
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
5 participants
@jfriv @AThousandShips @akien-mga @bruvzg @Calinou