Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GDScript code completion for literals #78288

Conversation

adamscott
Copy link
Member

When asking for code completion inside quotes (CTRL+space), the editor don't suggest anymore every identifier with quotes.

Fixes (partially) #62945, the issue still exists when you open the autocomplete window, then add quotes

@adamscott adamscott requested a review from a team as a code owner June 15, 2023 20:18
@adamscott adamscott added this to the 4.1 milestone Jun 15, 2023
@adamscott adamscott marked this pull request as draft June 16, 2023 21:22
@adamscott adamscott modified the milestones: 4.1, 4.2 Jun 16, 2023
- Fixes (partially) godotengine#62945, the issue still exists when you
  autocomplete, then open quotes
@HolonProduction
Copy link
Member

I applied this to the current master and it works. Even when adding the quotes after opening the window. (I guess #79387 fixed that.)

Screencast.from.2024-06-28.12-12-46.mp4

So if that was the reason to keep this a draft, it should be ready now.

@akien-mga
Copy link
Member

Superseded by #94082.

@akien-mga akien-mga closed this Aug 20, 2024
@akien-mga akien-mga removed this from the 4.x milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants