CI: Use gh-cli for changed files, and workaround codespell skip list bug #76842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
force-pushed
the
ci-codespell-fix-skip-list
branch
2 times, most recently
from
9a287bf to
15f666f
Compare
akien-mga
force-pushed
the
ci-codespell-fix-skip-list
branch
from
15f666f to
df761b8
Compare
akien-mga
changed the title
akien-mga
force-pushed
the
ci-codespell-fix-skip-list
branch
from
df761b8 to
8e3598d
Compare
For PRs, this should give a more accurate list, as the previous method would diff to the tip of the `master` branch, which could include new commits (and thus changed files) not present in the PR branch. codespell's `--skip` option doesn't work at all with folders when used together with an explicit list of paths to work with, so let's not use it.
akien-mga
force-pushed
the
ci-codespell-fix-skip-list
branch
from
8e3598d to
b3bb92a
Compare
This was referenced May 8, 2023
|
Cherry-picked for 4.0.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PRs, this should give a more accurate list, as the previous method would
diff to the tip of the
masterbranch, which could include new commits (andthus changed files) not present in the PR branch.
Also works around this upstream codespell bug: codespell-project/codespell#1915
Instead of relying on the skip list for folders, we exclude them manually.
.gitandbinshould never be part of the list of files changed in Git so we don't bother with them.And works around another misfeature of https://github.com/codespell-project/actions-codespell - the
check_hiddenoptional parameter is considered true if defined, even if set tofalse... the only way not to enable it is not to mention it.