Fix Skeleton3D & PhysicalBone3D editor errors #76592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamscott
reviewed
May 10, 2023
adamscott
approved these changes
May 10, 2023
spanzeri
force-pushed
the
fix-skeletons-and-bones
branch
from
a030f27 to
679ff6d
Compare
|
Thanks! |
|
Cherry-picked for 4.0.3. |
akien-mga
changed the title
akien-mga
added a commit
that referenced
this pull request
May 15, 2023
Fix Skeleton3D editor crash regression after #76592
lyuma
pushed a commit
to V-Sekai/godot
that referenced
this pull request
May 18, 2023
…eleton-editor Fix Skeleton3D editor crash regression after godotengine#76592
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at a separate issue, but I run into 2 errors with 3d skeleton and physical bones.
3d skeleton was the "attempting to load..." theme error because the editor was created in construction.
Physical bone 3d was never updated and did not correctly handle calls from EditorNode::_plugin_over_edit