Change in Project Manager #74561

gibionmillak · 2023-03-07T17:17:42Z

I made a small change in the project manager, make the interface a little more similar to the rest of the project.
I'm taking a "look" at the interface and seeing what could be improved.

I made a small change in the project manager, make the interface a little more similar to the rest of the project. :)

AThousandShips · 2023-03-07T17:18:43Z

This requires a proposal, it is a major change, and it makes the interface far less intuitive

This kind of major change needs a discussion and feedback, the interface now works very poorly for narrow windows, and is far more crowded

AThousandShips · 2023-03-07T17:25:05Z

The buttons now doesn't have text so how are you supposed to know what they do?

AThousandShips · 2023-03-07T17:26:47Z

editor/project_manager.cpp

+	for (int i = 0; i < editor_languages.size(); i++) {
+		String lang = editor_languages[i];
+		String lang_name = TranslationServer::get_singleton()->get_locale_name(lang);
+		language_btn->add_item(vformat("%s [%s]", lang_name, lang), i);


Why this change?

AThousandShips · 2023-03-07T17:31:23Z

Why have you removed the version? Also that and probably other controls are now left unused

YuriSizov · 2023-03-07T17:34:12Z

I'm taking a "look" at the interface and seeing what could be improved.

As mentioned, please make proposals for these changes first. It's okay if you also make a PR, but UI changes should be discussed and putting a lot of effort into making them before there is a consensus can result in a lot of wasted time for you.

Edit: I would also suggest focusing on identifying and explaining issues with the existing UI. Arbitrary changes that don't solve anything in particular are fun to make, but are unlikely to be considered. We try to be very pragmatic about those.

gibionmillak · 2023-03-07T17:39:01Z

The buttons now doesn't have text so how are you supposed to know what they do?

All I tried to do was reassign the buttons to the same style as the general interface... And like all other buttons they have tooltips.
90% of the engine's buttons have no text.

gibionmillak · 2023-03-07T17:41:46Z

Why have you removed the version? Also that and probably other controls are now left unused

I tried to make it more "clean", since the version information is still there. It was repetitive information.

AThousandShips · 2023-03-07T17:44:41Z

My bad missed the tooltips

And the version is convenient to not have to go to the help window, just like it's visible in the editor

AThousandShips · 2023-03-07T17:49:17Z

You have left a ton of functionality and items that now do nothing though, you need to do a lot of cleaning up

gibionmillak · 2023-03-07T17:51:01Z

You have left a ton of functionality and items that now do nothing though,

For example?

AThousandShips · 2023-03-07T17:51:43Z

The version button and related functionality, and settings_hb

I'm sorry, I don't mean to be rude but I see I come across as such, it's just doesn't seem like you've taken a proper look at the code before reworking it and missing a lot of what it does and what changes when you alter it

AThousandShips · 2023-03-07T18:43:05Z

My minimal suggestion is:

Leave version and language where they are
Have the search expand

But I think that putting the icons on a single row makes it harder to get an overview, and it makes the interface more crowded, it also makes it so you can't make the window as small and compact, and makes the search bar more crowded on small windows

jcostello · 2023-03-07T19:42:08Z

I like the changes. I would suggest you to do a proposal to explain all your changes so they can be consider for next versions

AThousandShips · 2023-03-07T19:44:38Z

@jcostello please don't comment just to boost

jcostello · 2023-03-07T19:56:55Z

Boost? This was active an hour ago. If you re-read my comment I just pointed out that I like the changes and suggest him to write a proposal

AThousandShips · 2023-03-07T19:57:47Z

You didn't add anything to the PR, no concrete details on the implementation, that's what I mean by boosting, the suggestion to make a propsal was already given twice

If you want to show your support just like the PR

Calinou · 2023-03-07T22:06:48Z

Unlabeled icon buttons should be avoided when possible, as it's hard to figure out what they'll do until you click them. We have no alternative for the 2D/3D editor toolbars as space is lacking there, but we're not lacking space in the project manager window.

dalexeev · 2023-03-08T06:16:38Z

We could keep labels on important buttons and hide on rarely used ones.

AThousandShips · 2023-03-08T07:51:33Z

Also you have made changes to the asset library viewer but you haven't shown how it looks now

seppoday · 2023-03-08T10:49:58Z

Hello, I've just created quick mockup to give some fundamentals to my opinion about this PR.

First of all I think there is room for improvement and I like OP idea, but some things are missing.

I totally agree that it should be proposal and in my opinion PR mockup kinda lacks key points why some things changed. In my opinion making it more like a menu in editor itself is not a great idea. Calinou explained it well.

So what I've changed and how it compares to this PR.

Moved buttons to top row. It is kinda good idea but I think labels are necesary and OP tried to make it more clean. With all buttons it is not that clean and few of those buttons are "embeded" to project. Those buttons are disabled. They only change to enabled when you click on project. So I've moved them to menu -> next point explains it.
I moved some buttons to contextual menu with 3 dots next to project itself. You can EDIT project by clicking on it or clicking 3 dots > EDIT. Those buttons are connected to project itself so I think it is better to have them under menu next to the project. It cleans up UI when those buttons are not needed and it connects those button more to the project itself.
With more horizontal space I've added 2 columns. "Godot version" and "last modified".
I've moved "About" button next to software version. It is kinda connected in my opinion and it saves space on bottom.
I've also added headers to project list to give more context.
Few small visual changes here and there. For example moving language to same line as sorting (to save space)

What problems this mockup solves?

Cleans up space
Creates more link between buttons that are global and buttons that are connected to project
Adds QOL improvements (project version and last modified)
We might remove sorting and just sort when you click on header itself. For example you can sort "last edited/modified" by clicking on heder name -> Second mockup shows that idea.

I created this mockup really quick and it is not my proposition. Just wanted to say that there is alot of things that we can change but we need proposal, discussion and probably a lot of mockup propositions. This is just example that you can make mockup with more thinking about solving problems and I think I've explained it well.... (?)

and Before and After:

Edit: Fixed some spacing, margins etc...because...perfectionism...

AThousandShips · 2023-03-08T14:06:45Z

Just to note that this kind of specific version info is not a feature in the current version, and not at all supported for pre 4.0, but other than that this looks much cleaner and less cluttered

I think the language should remain where it is to not take up as much space in the bar, as the size of the bar really controls how narrow the window can be, which is a thing that really needs to be considered

Also I think the loss of an easily accessible "run" button is not a good way to go, in general hiding basic functionality behind a context menu makes the interface far less easy to navigate

I honestly think the project manager is very good as it is however, and as it is the very first thing someone new sees making it complicated is not necessarily helpful

seppoday · 2023-03-08T14:14:50Z

Just to note that this kind of specific version info is not a feature in the current version, and not at all supported for pre 4.0, but other than that this looks much cleaner and less cluttered

I think the language should remain where it is to not take up as much space in the bar, as the size of the bar really controls how narrow the window can be, which is a thing that really needs to be considered

Also I think the loss of an easily accessible "run" button is not a good way to go, in general hiding basic functionality behind a context menu makes the interface far less easy to navigate

I honestly think the project manager is very good as it is however, and as it is the very first thing someone new sees making it complicated is not necessarily helpful

Yea sure you can go in that direction (rename and delete are still hidden in menu).

It is not proposal from my side, just wanted to comment on that PR that it should be discussed and first you need to find problems to fix them later not another way around. My mockups might not sell that idea too well. Sorry about that. Nonethless I also don't really have much of a problem with existing project manager. It might be improved a little but I never felt that way before checking this PR.

Your suggestions:

or even more emphasis on "New project" button (might be a little bit too much :P):

Sorry I have a problem with creating stuff that noone was asking for...

Ansraer · 2023-03-11T12:56:13Z

Sorry I have a problem with creating stuff that noone was asking for...

Don't worry about it @seppoday, you can never have too many mockups. I am not a UI/UX guy, but the few times I tried to build a user interface without having someone else design it the result was barely runctional.
Since OP has yet to create a proposal maybe you could do so? I really think you are on to something with your mockups and a proposal would give them more exporsure and feedback. Especially if you are willing to do a few more iterations.

Btw, some feedback for your last iteration: I like that the "Create new" button is more visible, but you might have overdone it a bit 😁 . Maybe you could come up with something in between?
I also don't think we need the edit buttons since I would expect double clicks on the project name to open it. And I am also not sure if the play button to be this visible. Maybe male it a bit more subtle? In my experience you rarely need it.

Riteo · 2023-03-15T16:45:10Z

I think that this should be discussed in a proposal. It's possible (and recommended) to make a PR for one but any discussion should go there.

Change in Project Manager

e529b9b

I made a small change in the project manager, make the interface a little more similar to the rest of the project. :)

AThousandShips reviewed Mar 7, 2023

View reviewed changes

YuriSizov added enhancement feature proposal topic:editor usability labels Mar 7, 2023

YuriSizov added this to the 4.x milestone Mar 7, 2023

seppoday mentioned this pull request Mar 18, 2023

Add project tags #75047

Merged

gibionmillak closed this by deleting the head repository Mar 27, 2023

YuriSizov added the archived label Mar 27, 2023

seppoday mentioned this pull request Jul 21, 2023

Project Manager navigation improve #79746

Closed

YuriSizov removed this from the 4.x milestone Dec 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change in Project Manager #74561

Change in Project Manager #74561

gibionmillak commented Mar 7, 2023

AThousandShips commented Mar 7, 2023 •

edited

Loading

AThousandShips commented Mar 7, 2023

AThousandShips Mar 7, 2023

AThousandShips commented Mar 7, 2023 •

edited

Loading

YuriSizov commented Mar 7, 2023 •

edited

Loading

gibionmillak commented Mar 7, 2023

gibionmillak commented Mar 7, 2023

AThousandShips commented Mar 7, 2023 •

edited

Loading

AThousandShips commented Mar 7, 2023 •

edited

Loading

gibionmillak commented Mar 7, 2023

AThousandShips commented Mar 7, 2023 •

edited

Loading

AThousandShips commented Mar 7, 2023

jcostello commented Mar 7, 2023

AThousandShips commented Mar 7, 2023 •

edited

Loading

jcostello commented Mar 7, 2023

AThousandShips commented Mar 7, 2023 •

edited

Loading

Calinou commented Mar 7, 2023 •

edited

Loading

dalexeev commented Mar 8, 2023 •

edited

Loading

AThousandShips commented Mar 8, 2023

seppoday commented Mar 8, 2023 •

edited

Loading

AThousandShips commented Mar 8, 2023

seppoday commented Mar 8, 2023 •

edited

Loading

Ansraer commented Mar 11, 2023

Riteo commented Mar 15, 2023

Change in Project Manager #74561

Change in Project Manager #74561

Conversation

gibionmillak commented Mar 7, 2023

AThousandShips commented Mar 7, 2023 • edited Loading

AThousandShips commented Mar 7, 2023

AThousandShips Mar 7, 2023

Choose a reason for hiding this comment

AThousandShips commented Mar 7, 2023 • edited Loading

YuriSizov commented Mar 7, 2023 • edited Loading

gibionmillak commented Mar 7, 2023

gibionmillak commented Mar 7, 2023

AThousandShips commented Mar 7, 2023 • edited Loading

AThousandShips commented Mar 7, 2023 • edited Loading

gibionmillak commented Mar 7, 2023

AThousandShips commented Mar 7, 2023 • edited Loading

AThousandShips commented Mar 7, 2023

jcostello commented Mar 7, 2023

AThousandShips commented Mar 7, 2023 • edited Loading

jcostello commented Mar 7, 2023

AThousandShips commented Mar 7, 2023 • edited Loading

Calinou commented Mar 7, 2023 • edited Loading

dalexeev commented Mar 8, 2023 • edited Loading

AThousandShips commented Mar 8, 2023

seppoday commented Mar 8, 2023 • edited Loading

AThousandShips commented Mar 8, 2023

seppoday commented Mar 8, 2023 • edited Loading

Ansraer commented Mar 11, 2023

Riteo commented Mar 15, 2023

AThousandShips commented Mar 7, 2023 •

edited

Loading

AThousandShips commented Mar 7, 2023 •

edited

Loading

YuriSizov commented Mar 7, 2023 •

edited

Loading

AThousandShips commented Mar 7, 2023 •

edited

Loading

AThousandShips commented Mar 7, 2023 •

edited

Loading

AThousandShips commented Mar 7, 2023 •

edited

Loading

AThousandShips commented Mar 7, 2023 •

edited

Loading

AThousandShips commented Mar 7, 2023 •

edited

Loading

Calinou commented Mar 7, 2023 •

edited

Loading

dalexeev commented Mar 8, 2023 •

edited

Loading

seppoday commented Mar 8, 2023 •

edited

Loading

seppoday commented Mar 8, 2023 •

edited

Loading