Fix some ways to create inconsistent Viewport size states #73188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sauermann
force-pushed
the
fix-inconsistent-viewport-size
branch
from
dac844c to
6f08463
Compare
bruvzg
approved these changes
Feb 13, 2023
In the editor, it was possible to set the size of a `SubViewport` even in cases where a parent `SubViewportContainer` had stretch enabled. This PR disables editing a `SubViewport.size` while the parent disallows it and it makes necessary adjustments during `NOTIFICATION_ENTER_TREE`.
Sauermann
force-pushed
the
fix-inconsistent-viewport-size
branch
from
6f08463 to
34a7fc7
Compare
|
Thanks! |
|
Cherry-picked for 4.0.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the editor, it was possible to set the size of a
SubViewporteven in cases where a parentSubViewportContainerhad stretch enabled (which automatically adjusts the size).This PR disables editing a
SubViewport.sizewhile the parent disallows it and it makes necessary adjustments duringNOTIFICATION_ENTER_TREE.fix #73160 by disallowing to create the situation where the described problem can happen
continuation of #66906
supersedes #72556