Split pause() from AnimationPlayer's stop()

[KoBeWi]

Counter-PR to #71208
This is a minimal change, unlike #56645

stop() will function exactly the same as it did.
stop(false) is now pause().
Everything else stays the same.

[TokageItLab]

I believe _stop_internal() should be implemented on the tween side as well, since pause is just a function that omits some lines in stop, this will reduce the number of duplicates.

void Tween::_stop_internal(bool p_reset) {
	running = false;
	dead = false;
	if (p_reset) {
		started = false;
		total_time = 0;
	}
}

void Tween::stop() {
	_stop_internal(true);
}

void Tween::pause() {
	_stop_internal(false);
}

BTW, I think there is no reason not to set dead to false in pause.

[KoBeWi]

Tween's _stop_internal() would be much shorter than in AnimationPlayer, but why not I guess. Although it should be done in a separate PR.

[YuriSizov]

Docs could benefit from "See also [method the_other_method]."

[TokageItLab]

Tween::pause() is certainly short, but I am concerned about inconsistency. If this PR changes the AnimationPlayer for making consistent with Tween, I would recommend that the Tween match it as well.

[KoBeWi]

Ok I added it as a second commit. I also fixed inconsistent naming of a private method.

[TokageItLab]

I agree with this more than #71208. Without deciding whether or not to implement pause() we cannot go forward. The time has come.

[YuriSizov]

This is a minimal change, unlike #56645

Does this address the issues linked in there in any way? And how does this PR relate to your own #33733 for that matter?

[KoBeWi]

Does this address the issues linked in there in any way?

Not really. The issues were mostly about play() vs start()/resume(), but that change has some unwanted side-effects.

I also didn't want to change the behavior of stop(), so #33733 is still relevant (and also stirred some discussion).

[YuriSizov]

LGTM. I guess adding this to the project converter may be hard due to a very ambiguous name?

[KoBeWi]

The conversion would have to handlestop(true) and stop(false), so maybe it's not that ambiguous.

EDIT:
Ok converter does not allow that. It would need to be modified.

[akien-mga]

Thanks!