Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Fix RichTextLabel discards appended BBCode text on window resize when using DynamicFont #70593

Merged
merged 1 commit into from
Jan 9, 2023
Merged

[3.x] Fix RichTextLabel discards appended BBCode text on window resize when using DynamicFont #70593

merged 1 commit into from
Jan 9, 2023

Conversation

OsakiTsukiko
Copy link

Fixes #62640

@OsakiTsukiko OsakiTsukiko requested a review from a team as a code owner December 26, 2022 15:11
@YeldhamDev YeldhamDev added this to the 3.x milestone Dec 27, 2022
@YeldhamDev YeldhamDev linked an issue Dec 27, 2022 that may be closed by this pull request
RichTextLabel's BBCode is reset to the initial value when the window is resized if a DynamicFont is used #62640
Closed
@OsakiTsukiko
Copy link
Author

I think that should fix the formatting issue

bruvzg
bruvzg approved these changes Jan 3, 2023
View reviewed changes
scene/gui/control.h Outdated Show resolved Hide resolved
@akien-mga akien-mga modified the milestones: 3.x, 3.6 Jan 9, 2023
@akien-mga
Copy link
Member

Pushed a minor refactor to reduce code duplication.

@akien-mga akien-mga added the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Jan 9, 2023
@akien-mga akien-mga merged commit 9832c9d into godotengine:3.x Jan 9, 2023
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@akien-mga akien-mga mentioned this pull request Jan 9, 2023
Closed
@OsakiTsukiko OsakiTsukiko deleted the issue-62640 branch January 9, 2023 14:38
@akien-mga
Copy link
Member

Cherry-picked for 3.5.2.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.

RichTextLabel's BBCode is reset to the initial value when the window is resized if a DynamicFont is used
4 participants
@OsakiTsukiko @akien-mga @bruvzg @YeldhamDev