fix exporting Android APPLICATION_ATTRIBS (3.X) #69024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
the
cherrypick:3.5
|
Thanks! |
|
Cherry-picked for 3.5.2 |
timothyqiu
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to add a tag to the inside of <application ...> in AndroidManifest.xml
I noticed that godot\platform\android\export\export_plugin.cpp did appear to support adding a [application_attribs] section to AndroidManfiest.conf. Which should then get inserted into <application ...> in AndroidManifest.xml
But it didn't work. The reason why is when export_plugin.cpp parses AndroidManifest.conf it upper cases the section names: "APPLICATION_ATTRIBS", but then later it was looking up using lower case "application_attribs"
So the simple fix was to upper case "APPLICATION_ATTRIBS" in code
Submitting pull request only against version 3.x because export_plugin.cpp in Master appears to be significantly different.