Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix shader compiler asan out of bounds #68813

Merged

Conversation

dzil123
Copy link
Contributor

@dzil123 dzil123 commented Nov 18, 2022

Cherrypick of #68718 for 3.x.

Tested working with use_ubsan=yes use_asan=yes.

Compatible with 3.5.

@dzil123 dzil123 requested a review from a team as a code owner November 18, 2022 02:30
@dzil123 dzil123 force-pushed the v3_fix_fog_shader_buffer_overflow branch 2 times, most recently from cb068b6 to 5bafdcf Compare November 18, 2022 03:03
@dzil123 dzil123 force-pushed the v3_fix_fog_shader_buffer_overflow branch from 5bafdcf to aa0b91c Compare November 18, 2022 03:24
@Chaosus Chaosus added this to the 3.x milestone Nov 18, 2022
@akien-mga akien-mga modified the milestones: 3.x, 3.6 Nov 18, 2022
@akien-mga akien-mga added the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Nov 18, 2022
@akien-mga akien-mga merged commit ab65273 into godotengine:3.x Nov 18, 2022
@akien-mga
Copy link
Member

Thanks!

@timothyqiu
Copy link
Member

Cherry-picked for 3.5.2

@timothyqiu timothyqiu removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants