Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After
PCKPacker.flush()
, the file is closed and it is invalid to callflush()
oradd_file()
, but the closed file isn't properly detected because the FileAccess remains nonnull andadd_file()
doesn't check for a closed file, causingflush()
to spam error messages andadd_file()
to miss the error. This PR fixes that.With this script:
Error messages before:
Error messages after:
Compatible with 3.5.