expose ARVRInterface::get_transform_for_eye to gdscript #68384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's awesome that you got stereoscopic mirrors going! Exposing this method to GDScript sounds fine to me. However, I think you'll need to make the Godot 4 PR and have it get merged before this can be merged into Godot 3. |
Thanks, I just found a workaround about the viewports not rendering in godot 4, so it can be implemented now, I'll work on the PR for master then |
cheece
force-pushed
the
expose_get_transform_for_eye
branch
from
e0264db to
872e36b
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
By exposing ARVRInterface::get_transform_for_eye, it's possible to implement true stereoscopic mirrors and portals in VR previously impossible in godot.
I made this specifically for 3.x since viewport textures seem to be not working on godot 4 with openxr yet and I couldn't make it work, but it 's rather easy to port (it would be get_transform_for_view instead)
I made a demo using the method to render stereoscopic mirrors in VR, it can be found here:
https://github.com/cheece/godot-vr-mirror-test
update:
I found a workaround about the viewports not rendering in godot 4 and I got it working finally, so I made a PR to master too #68390