Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle closed splines in Collada importer #67834

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Handle closed splines in Collada importer #67834

merged 1 commit into from
Oct 27, 2022

Conversation

Klowner
Copy link
Contributor

@Klowner Klowner commented Oct 24, 2022

@Klowner Klowner requested a review from a team as a code owner October 24, 2022 14:37
@Calinou Calinou added bug topic:import topic:3d cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Oct 24, 2022
@Calinou Calinou added this to the 4.0 milestone Oct 24, 2022
fire
fire approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to test this as I used gltf2 these days, but don't let me stop you from fixing a bug relevant to your uses.

@fire fire requested a review from a team October 24, 2022 15:27
@Klowner
Copy link
Contributor Author

Klowner commented Oct 24, 2022 •
edited
Loading

Same! Just squashing bugs that are old enough to talk 😉 (I did test this though!)

@clayjohn clayjohn merged commit 8a5e0b8 into godotengine:master Oct 27, 2022
@clayjohn
Copy link
Member

Looks good, thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.6.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Nov 30, 2022
@Klowner Klowner deleted the collada-closed-curves-16658 branch November 30, 2022 14:26
@timothyqiu
Copy link
Member

Cherry-picked for 3.5.2

@timothyqiu timothyqiu removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

@reduz reduz reduz approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:import topic:3d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Imported curve from Blender is not closed.
7 participants
@Klowner @clayjohn @akien-mga @timothyqiu @fire @reduz @Calinou