-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't try to import unknown dependency from scan #67664
Don't try to import unknown dependency from scan #67664
Conversation
Only import dependency we know how to import, since custom resource may have .gd in dependency list which doesn't have an importer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved in today's PR meeting
Thanks! |
Cherry-picked for 3.6. |
Cherry-picked for 3.5.2 |
Is this supposed to be fixed for 4.x? I'm on 4.1 Beta 2 and keep getting the Update: It's a documentation/nondescript error issue. Not overriding, or returning 0.0, from _get_priority, was causing it. |
If that's the case, we should define a default return value that makes the import plugin be successful out of the box. |
Only import dependency we know how to import, since custom resource may have .gd in dependency list which doesn't have an importer
I was encountering
BUG: File queued for import, but can't be imported, importer for type '' not found.
when I modified my resource file that has custom importer addon. The code was trying to reimport script file (".gd") of my resource, which can't be imported.After seeing similar issues ( #45524 , #46288 and #51816 ), I think this is the right thing to do?
Should fix #46288
Bugsquad edit: