Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to import unknown dependency from scan #67664

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

WindyDarian
Copy link
Contributor

@WindyDarian WindyDarian commented Oct 20, 2022

Only import dependency we know how to import, since custom resource may have .gd in dependency list which doesn't have an importer

I was encountering BUG: File queued for import, but can't be imported, importer for type '' not found. when I modified my resource file that has custom importer addon. The code was trying to reimport script file (".gd") of my resource, which can't be imported.

After seeing similar issues ( #45524 , #46288 and #51816 ), I think this is the right thing to do?

Should fix #46288

Bugsquad edit:

Only import dependency we know how to import, since custom resource may have .gd in dependency list which doesn't have an importer
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in today's PR meeting

@akien-mga akien-mga merged commit c950d17 into godotengine:master Nov 29, 2022
@akien-mga akien-mga added cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Nov 29, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.6.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Nov 30, 2022
@timothyqiu
Copy link
Member

Cherry-picked for 3.5.2

@timothyqiu timothyqiu removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Dec 5, 2022
@caimantilla
Copy link

caimantilla commented Jun 15, 2023

Is this supposed to be fixed for 4.x? I'm on 4.1 Beta 2 and keep getting the BUG: File queued for import, but can't be imported, importer for type '' not found. error when trying to import a binary file as custom resource. Whether _get_resource_type returns "Resource" or "DBAM_AnimationData" doesn't affect this. Is there some workaround I'm missing?

Update: It's a documentation/nondescript error issue. Not overriding, or returning 0.0, from _get_priority, was causing it.

@Calinou
Copy link
Member

Calinou commented Jun 15, 2023

Update: It's a documentation/nondescript error issue. Not overriding, or returning 0.0, from _get_priority, was causing it.

If that's the case, we should define a default return value that makes the import plugin be successful out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants