Hide text of RichTextLabel if BBCode is enabled #67255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
added
enhancement
usability
topic:gui
cherrypick:3.5
akien-mga
approved these changes
Oct 11, 2022
bruvzg
approved these changes
Oct 11, 2022
|
Thanks! |
|
Cherry-picked for 3.5.2 |
timothyqiu
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master,
textandbbcode_textare merged into 1 property. But in 3.x there is a rather big usability problem where you enable bbcode and then set text, only to discover that you put your text in a wrong property. When bbcode is enabled,bbcode_textgets mirrored intotextproperty, so anything you put into text gets erased.This PR hides
textproperty when BBCode is enabled.It's only hidden in the inspector, everything else works as before, so it's 100% compatible change.