Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove expression base node for transitions #67020

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Remove expression base node for transitions #67020

merged 1 commit into from
Oct 7, 2022

Conversation

GuilhermeGSousa
Copy link
Contributor

As discussed #66573, this PR removes expression base nodes from transitions, hoping to close #62530.

As AnimationTrees are nodes and transitions are resources, referencing a scene node (expression_base_node) makes sense for the former, but not the latter.

@GuilhermeGSousa GuilhermeGSousa requested review from a team as code owners October 7, 2022 09:19
fire
fire approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@fire fire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in rocketchat animation chasnnel with lyuma briefly.

I talk about it on the PR, but since AnimationTrees are Nodes and transitions are Resources, referencing a scene node makes sense for the former, but not for the latter

@akien-mga akien-mga added this to the 4.0 milestone Oct 7, 2022
@akien-mga akien-mga merged commit c723125 into godotengine:master Oct 7, 2022
@akien-mga
Copy link
Member

Thanks!

@GuilhermeGSousa GuilhermeGSousa deleted the remove-transition-expression-node branch October 7, 2022 12:55
@RedMser RedMser mentioned this pull request Nov 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

Assignees
No one assigned
Labels
breaks compat bug topic:animation
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Advance expression for AnimationTree doesn't seem to work
3 participants
@GuilhermeGSousa @akien-mga @fire