Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null in android keyboard handling. #66942

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Fix null in android keyboard handling. #66942

merged 1 commit into from
Oct 5, 2022

Conversation

jasonwinterpixel
Copy link
Contributor

3.x version of #66941

There is a potential null

10-05 11:11:15.889 13988 13988 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String android.view.KeyEvent.getCharacters()' on a null object reference

pKeyEvent can be null https://developer.android.com/reference/android/widget/TextView.OnEditorActionListener

This is reproducible when pressing the Enter key in the 1password keyboard in a godot text view on android.

Simply check for the null.

@jasonwinterpixel jasonwinterpixel requested a review from a team as a code owner October 5, 2022 17:21
@jasonwinterpixel jasonwinterpixel mentioned this pull request Oct 5, 2022
Merged
m4gr3d
m4gr3d approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@m4gr3d m4gr3d merged commit d6ebb99 into godotengine:3.x Oct 5, 2022
@akien-mga akien-mga added this to the 3.6 milestone Oct 5, 2022
@akien-mga akien-mga added the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Oct 5, 2022
@timothyqiu
Copy link
Member

Cherry-picked for 3.5.2

@timothyqiu timothyqiu removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4gr3d m4gr3d m4gr3d approved these changes

Assignees
No one assigned
Labels
bug platform:android topic:input
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
4 participants
@jasonwinterpixel @timothyqiu @m4gr3d @akien-mga